Remove object shorthand from PegJS grammar #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not subjected to Babel transformations, apparently.
|
fixes the build for me :) |
Closed
|
Previously: #426 (comment) |
hypest
added a commit
that referenced
this pull request
Nov 8, 2019
* WC: #479: Adding help icon and modal to unsupported block. Also putting original name in place of 'Unsupported'. * WC: #479: Adding in unit tests for the component. * WC: #479: Changing the help icon press surface to the whole block because the small icon was too hard to press. Also rearranging the BottomSheet to work the height paddings out correctly. * WC: #479: Changing accessibility label and adding comment. * WC: #479: Adding in text/buttons to match later design. * WC: issue #479: Changing only the question mark icon to be tappable for the help block. Few color changes. Adding some text to the help block. * Display 'unsupported' on all unsupported blocks on mobile * Update the test snapshot of Unsupported block on mobile * Need to mock styling on mobile * Adjust tests to latest changes * Display the block name in quotes, for clarity * Dark mode of info text, title and description * sprintf to compose string, separate strings per platform * Wrap JSX in the grouping operator, as usual * Remove dismiss button, not used in other bottom-sheets * Remove unused import * Revise sprintf format to green the linter * Update tests after removing the Close button * Wrap more JSX in the grouping operator, as usual * Adjust the info-icon color * Different colors for the icon on the sheet * Remove local mock, using the global styleMock.js instead * Enable testing both mobile platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not subjected to Babel transformations, apparently.