Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: Update: Make button a content block. #47936

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

jorgefilipecosta
Copy link
Member

This PR makes button a content block. This makes sure that when there is contentLocking buttons appear on the inspector list of content blocks making it easier for the user to change text and links of the button in a given content locked pattern.

@jorgefilipecosta jorgefilipecosta force-pushed the update/make-button-a-content-block branch from 44def51 to 3978bad Compare February 9, 2023 18:36
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Flaky tests detected in 3978bad.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4137360291
📝 Reported issues:

@jorgefilipecosta jorgefilipecosta merged commit 1c087d4 into trunk Feb 13, 2023
@jorgefilipecosta jorgefilipecosta deleted the update/make-button-a-content-block branch February 13, 2023 18:17
@github-actions github-actions bot added this to the Gutenberg 15.2 milestone Feb 13, 2023
@jorgefilipecosta
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@DaisyOlsen DaisyOlsen added [Type] Enhancement A suggestion for improvement. [Package] Block library /packages/block-library [Block] Buttons Affects the Buttons Block labels Feb 14, 2023
@DaisyOlsen DaisyOlsen changed the title Update: Make button a content block. Button: Update: Make button a content block. Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block [Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants