Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToolsPanel: refactor Storybook examples to TypeScript, fix types inconsistencies #47944

Merged
merged 21 commits into from
Feb 13, 2023
Merged

ToolsPanel: refactor Storybook examples to TypeScript, fix types inconsistencies #47944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
78dde7f
Rename files
ciampo Feb 9, 2023
cb303b8
Fix imports
ciampo Feb 9, 2023
ef78ee9
Allow panelId to be null across all types
ciampo Feb 4, 2023
e7c1977
`ToolsPanel`: mark `hasInnerWrapper` and `shouldRenderPlaceholderItem…
ciampo Feb 4, 2023
25cd91f
`ToolsPanelItem`: mark `resetAllFilter` as optional, assign `noop` de…
ciampo Feb 4, 2023
1496c0e
`ToolsPanelItem`: change `isShownByDefault` to be optional, assign de…
ciampo Feb 4, 2023
cd98b45
Storybook examples: add component and state types
ciampo Feb 4, 2023
c79f4f5
Storybook example: ignore unsolved errors, add TODO notes
ciampo Feb 4, 2023
21ec6c6
Add Storybook meta object
ciampo Feb 4, 2023
38ad0a1
Fix type errors in Storybook examples
ciampo Feb 5, 2023
e174f5a
Remove extraneous `isFirstToolsPanelItemShownByDefault` prop from Sto…
ciampo Feb 9, 2023
0df37ca
CHANGELOG
ciampo Feb 9, 2023
2780f5d
Fix resetAll prop forwarding typo
ciampo Feb 10, 2023
fa0f4cf
Update `ResetAllFilter` type to receive and return data. Update READMEs
ciampo Feb 10, 2023
02528f6
Update READMEs to sync `resetAll` and `resetAllFilter` types and desc…
ciampo Feb 10, 2023
82f83bf
Remove @ts-ignore comments after updating the `ResetAllFilter` type
ciampo Feb 10, 2023
3577c50
Remove unnecessary `ToolsPanelWithItemGroupSlot` story
ciampo Feb 10, 2023
4aad2e2
update `resetAll` prop descritption in types JSDocs
ciampo Feb 10, 2023
8673259
Fix ToolsPanel component exports
aaronrobertshaw Feb 13, 2023
86d61c7
Draft ToolsPanel JSDoc example comment
aaronrobertshaw Feb 13, 2023
c6ecc6b
Update CHANGELOG to avoid duplicate sections
ciampo Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Bug Fix

- `ToolsPanel`: fix type inconsistencies between types, docs and normal component usage ([47944](https://github.com/WordPress/gutenberg/pull/47944)).
- `SelectControl`: Fix styling when `multiple` prop is enabled ([#47893](https://github.com/WordPress/gutenberg/pull/43213)).

### Enhancements
Expand All @@ -28,6 +29,7 @@
- `ToolsPanel`: Allow display of optional items when values are updated externally to item controls ([47727](https://github.com/WordPress/gutenberg/pull/47727)).
- `ToolsPanel`: Ensure display of optional items when values are updated externally and multiple blocks selected ([47864](https://github.com/WordPress/gutenberg/pull/47864)).
- `Navigator`: add more pattern matching tests, refine existing tests ([47910](https://github.com/WordPress/gutenberg/pull/47910)).
- `ToolsPanel`: Refactor Storybook examples to TypeScript ([47944](https://github.com/WordPress/gutenberg/pull/47944)).

## 23.3.0 (2023-02-01)

Expand Down
Loading