Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move site editor 6.2 specific code to the right file #48023

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

youknowriad
Copy link
Contributor

I've made a small mistake in #47777 (comment) this PR just moves this file content to the 6.2 folder.

@youknowriad youknowriad added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 13, 2023
@youknowriad youknowriad self-assigned this Feb 13, 2023
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Riad! Will you be able to create the trac ticket and the back port PR to core?

@ntsekouras
Copy link
Contributor

Actually I think this could be part of https://core.trac.wordpress.org/ticket/57631.

@youknowriad
Copy link
Contributor Author

Yeah, it's just two lines to remove.

@youknowriad youknowriad enabled auto-merge (squash) February 13, 2023 12:28
@youknowriad youknowriad merged commit 490becb into trunk Feb 13, 2023
@youknowriad youknowriad deleted the move/62-specific-code branch February 13, 2023 12:51
@github-actions github-actions bot added this to the Gutenberg 15.2 milestone Feb 13, 2023
@ntsekouras
Copy link
Contributor

Cherry-picked this PR to the wp/6.2 branch.

@ntsekouras ntsekouras removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 14, 2023
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Feb 14, 2023
…irect.

Removes the server-side redirection if missing `postType` and `postId` query args when visiting Site Editor. Why? This redirect is no longer needed as the routing is now handled client side (via [55333]).

References:
* [WordPress/gutenberg#48023 Gutenberg PR 48023]
* [WordPress/gutenberg#47777 Gutenberg PR 47777]

Follow-up to [55333], [53413], [53093].

Props ntsekouras, youknowriad.
Fixes #57716.

git-svn-id: https://develop.svn.wordpress.org/trunk@55338 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Feb 14, 2023
…irect.

Removes the server-side redirection if missing `postType` and `postId` query args when visiting Site Editor. Why? This redirect is no longer needed as the routing is now handled client side (via [55333]).

References:
* [WordPress/gutenberg#48023 Gutenberg PR 48023]
* [WordPress/gutenberg#47777 Gutenberg PR 47777]

Follow-up to [55333], [53413], [53093].

Props ntsekouras, youknowriad.
Fixes #57716.
Built from https://develop.svn.wordpress.org/trunk@55338


git-svn-id: http://core.svn.wordpress.org/trunk@54871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot pushed a commit to gilzow/wordpress-performance that referenced this pull request Feb 14, 2023
…irect.

Removes the server-side redirection if missing `postType` and `postId` query args when visiting Site Editor. Why? This redirect is no longer needed as the routing is now handled client side (via [55333]).

References:
* [WordPress/gutenberg#48023 Gutenberg PR 48023]
* [WordPress/gutenberg#47777 Gutenberg PR 47777]

Follow-up to [55333], [53413], [53093].

Props ntsekouras, youknowriad.
Fixes #57716.
Built from https://develop.svn.wordpress.org/trunk@55338


git-svn-id: https://core.svn.wordpress.org/trunk@54871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@DaisyOlsen DaisyOlsen added [Type] Code Quality Issues or PRs that relate to code quality [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Feb 14, 2023
VenusPR added a commit to VenusPR/Wordpress_Richard that referenced this pull request Mar 9, 2023
…irect.

Removes the server-side redirection if missing `postType` and `postId` query args when visiting Site Editor. Why? This redirect is no longer needed as the routing is now handled client side (via [55333]).

References:
* [WordPress/gutenberg#48023 Gutenberg PR 48023]
* [WordPress/gutenberg#47777 Gutenberg PR 47777]

Follow-up to [55333], [53413], [53093].

Props ntsekouras, youknowriad.
Fixes #57716.
Built from https://develop.svn.wordpress.org/trunk@55338


git-svn-id: http://core.svn.wordpress.org/trunk@54871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants