Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabPanel: Refactor unit tests in prep for controlled component updates #48086

Merged
merged 12 commits into from
Feb 27, 2023
Merged

TabPanel: Refactor unit tests in prep for controlled component updates #48086

merged 12 commits into from
Feb 27, 2023

Commits on Feb 24, 2023

  1. Get clean slate for TabPanel tests

    @aaronrobertshaw @ciampo
    aaronrobertshaw authored and ciampo committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    00370ad View commit details
    Browse the repository at this point in the history

  2. Draft new tests structure

    @aaronrobertshaw @ciampo
    aaronrobertshaw authored and ciampo committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    37be2e0 View commit details
    Browse the repository at this point in the history

  3. Add notes about tests to add

    @ciampo
    ciampo committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    d4f4ccd View commit details
    Browse the repository at this point in the history

  4. Add a11y and semantics unit test

    @ciampo
    ciampo committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    38a5b62 View commit details
    Browse the repository at this point in the history

  5. Add more tests around tab focus and selection with point and keyboard

    @ciampo
    ciampo committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    e022fb2 View commit details
    Browse the repository at this point in the history

  6. Add tooltip tests

    @ciampo
    ciampo committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    904a5d9 View commit details
    Browse the repository at this point in the history

  7. Improve "no matching initialTabName" test

    @ciampo
    ciampo committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    52d5610 View commit details
    Browse the repository at this point in the history

  8. Add more tests on fallback selection when selected tab is disabled

    @ciampo
    ciampo committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    8f88dc6 View commit details
    Browse the repository at this point in the history

  9. Improve stories by logging action and adding a "with icons" example

    @ciampo
    ciampo committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    dc55628 View commit details
    Browse the repository at this point in the history

  10. Render tab tooltips into popover slot 

    When tooltips are rendered inline i.e. within the tab's button, it interferes with keyboard navigation.
    @aaronrobertshaw @ciampo
    aaronrobertshaw authored and ciampo committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    2609bdc View commit details
    Browse the repository at this point in the history

  11. Improve tooltip tests

    @ciampo
    ciampo committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    214a313 View commit details
    Browse the repository at this point in the history

  12. CHANGELOG

    @ciampo
    ciampo committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    4f919b4 View commit details
    Browse the repository at this point in the history