Fix the site editor home page loading when installed in a subdirectory #48363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
youknowriad
requested review from
Mamaduka,
audrasjb,
ellatrix,
ndiego and
annezazu
youknowriad
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: +12 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 875082a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4253134828
|
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: f83d85c |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #48292
What?
When WP is installed in a subdirectory, the site editor would show a loader indefinitely. This PR fixes that.
How?
The URL of the home page is not always
/. This PR uses thegetSiteselector to grab the url of the frontend and retrieve the template based on that URL.Testing Instructions
1- Have a WP install in a subdirectory
2- Load the site editor
3- The front page should load properly.