-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML API: Pull updates from development in Core #48378
Conversation
Flaky tests detected in 79a5406aea243fca05f9a50be758adf79975f7e2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4258643113
|
e23dddd
to
79a5406
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
This commit pulls in updates from development of the HTML API happening in Core. - HTML API: Fix finding bookmarks set on closing tag WP_HTML_Tag_Processor 83ae6b790e5f1d361b5b128063f74bf253b55397 - HTML API: Set $this->html to protected to support subclassing 552178a95ad38c924f9d9821d3c75d0bf9926748
79a5406
to
c846c62
Compare
Since those changes will be in WP 6.2, we also need to backport them into Gutenberg's 6.2 compat layer. This is done in |
In the 6.2 compat layer, support bookmarks pointing to closing tags. This is for parity with Core in WP 6.2, see WordPress/wordpress-develop#4115 and [r55407](https://core.trac.wordpress.org/changeset/55407). Note that these changes have already been backported to GB's 6.**3** compat layer in #48378. However, since the change will be in WP 6.2, we also have to apply it to GB's 6.2 compat layer.
In the 6.2 compat layer, support bookmarks pointing to closing tags. This is for parity with Core in WP 6.2, see WordPress/wordpress-develop#4115 and [r55407](https://core.trac.wordpress.org/changeset/55407). Note that these changes have already been backported to GB's 6.**3** compat layer in #48378. However, since the change will be in WP 6.2, we also have to apply it to GB's 6.2 compat layer.
Thanks @ockham! - sorry I didn't think about that. |
This commit pulls in updates from development of the HTML API happening in Core.
HTML API: Fix finding bookmarks set on closing tag WP_HTML_Tag_Processor
83ae6b790e5f1d361b5b128063f74bf253b55397
HTML API: Set $this->html to protected to support subclassing
552178a95ad38c924f9d9821d3c75d0bf9926748
Created by copying tag processor class into
compat/wordpress-6.3
and renaming the class.