[Mobile] - E2E helpers - Update dismissKeyboard helper #48415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
the
Mobile App - i.e. Android or iOS
|
Size Change: +827 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d3bc4e2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4283010705
|
- It adds new waitForElementToBeDisplayedByXPath helper - It adds a new functionality for dismissKeyboard which will handle waiting until the keyboard is fully hidden by taking the initial position of the Add block button in the editor. - It adds setupInitialValues which will handle initial values we want to have available during the tests
geriux
force-pushed
the
rnmobile/fix-e2e-helpers
branch
from
a2231b3 to
298f7d1
Compare
Merged
2 tasks
geriux
commented
Feb 24, 2023
| @@ -60,10 +60,6 @@ describe( 'Gutenberg Editor tests for Block insertion', () => { | |||
| await editorPage.sendTextToParagraphBlock( 1, testData.longText ); | |||
| // Should have 3 paragraph blocks at this point. | |||
|
|
|||
| if ( isAndroid() ) { | |||
| await editorPage.dismissKeyboard(); | |||
There was a problem hiding this comment.
This is now handled within dismissKeyboard if the orientation is LANDSCAPE (on Android) it will hide the Keyboard using the driver's hideDeviceKeyboard method.
fluiddot
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
LGTM 🎊 !
I checked the E2E tests in the GB-mobile PR and all succeeded 🎊.
I added a comment regarding a potential alternative to wait for the keyboard to be hidden. I haven't checked it myself so it might not work, so consider this suggestion optional. Thanks!
Comment on lines
35
to
37
| const ADD_BLOCK_ID = isAndroid() | ||
| ? 'Add block, Double tap to add a block' | ||
| : 'Add block'; |
There was a problem hiding this comment.
Nitpick: Since this is a constant I'd consider having it before the definition of functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
This PR updates some existing E2E helpers and it adds new ones.
Why?
To address an issue with a recently added visual test that fails in
trunkin the Gutenberg Mobile repo.How?
It introduces
setupInitialValueswhich for now will store the initial location of theAdd blockbutton (when the editor loads). This will be used to detect if the keyboard was fully dismissed and the button is back to the initial position. Relying onsleepvalues is unreliable on CI so I think this approach might be more stable.Updates
dismissKeyboardto take into account the location of theAdd blockbutton by calling the newwaitForKeyboardToBeHiddenhelper.It adds
waitForElementToBeDisplayedByXPathto wait for elements to be visible by XPaths.Testing Instructions
CI checks should pass on both Gutenberg and Gutenberg mobile.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A