Mobile - Fix parsing of css units for null matched values #48484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Status] In Progress
|
Size Change: +13 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
geriux
added
Mobile App - Automation
dcalhoun
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRS:
What?
Follow-up of #47258
Why?
There is a case for a theme that has
var:preset|font-size|mediumvalues and it was crashing the editor as thematchvalue wasnull. This fix will also prevent other values that can't be parsed from going through the rest of the code.How?
Checking if the matched value is not null before continuing parsing the value.
Testing Instructions
Precondition: A site using a block-based theme like
BitácoraTesting Instructions for Keyboard
N/A
Screenshots or screencast