-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Editor: update the edit button #48584
Conversation
Size Change: -981 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
Flaky tests detected in c28933d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4292610071
|
Happy to try this, looks good. Occasionally the edit icon will look top heavy, but it's actually correctly centered: I do wonder, however, if we should use the new edit-small icon here instead? Nothing blocking, but curious of your thoughts, @jameskoster @SaxonF |
I think it looks top heavy because the icon itself has (imo) some peculiar dimensions. Particularly the pencil peeking outside of the 16px square. I don't have a strong preference on either. This obviously veers into component territory, but the blue hover looks a bit awkward to me, and the icon disappears entirely on click: I don't think we've quite nailed down the design for these buttons in the dark material just yet. So for now perhaps it would be best to align with the Back button? |
Ok, with the last commit, all these buttons are actually using the same component with the same styles, so we can change them in a unique place. |
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: aa903d5 |
What?
This PR updates the design of the "edit" button in the site editor sidebar. Now that you can click the canvas to edit, the "primary" edit button was a bit too prominent.
I'm using the same style, we're using for the "plus" icon to add templates in the "templates" sidebar.