Don't add Post Content layout styles to title in the post editor. #48663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Type] Bug
|
Size Change: -6 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 22679c5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4310804362
|
andrewserong
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Nice work @tellthemachines, glad to see it was a simple fix to ensure that the post content block layout rules don't affect the post title block in the post editor 👍
This is testing well for me across a variety of blocks and classic themes.
One thing I noticed in testing that isn't related to this PR, is that while running emptytheme there's no spacing between the post title block and the first block of the post content.
I believe this is because we don't have layout running on the parent of both areas of the document (since the parent is body currently). I wonder if it'd be worth at some point seeing if we can add layout one level up, so that we can apply default spacing between the title and the post content area? (I see themes like TT3 deal with this by including margin rules for the post content block as part of the theme). Definitely not a blocker for this PR, though!
LGTM! ✨
|
Thanks for reviewing @andrewserong! |
tellthemachines
added
the
Backport to WP 6.7 Beta/RC
ntsekouras
pushed a commit
that referenced
this pull request
Mar 7, 2023
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 83ddde7 |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #48579.
If Post Content block has custom layout settings (e.g. if it's justified right and/or has a narrow content width) the post title in the post editor shouldn't get those styles, as they don't necessarily reflect the layout of the Post Title block in the template.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast