-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Add block transforms integration tests for Container blocks #48883
[RNMobile] Add block transforms integration tests for Container blocks #48883
Conversation
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
Flaky tests detected in 8cd050596c0b2639c292efe3d13ce8c44c933152. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4353953832
|
f80ab91
to
344a14b
Compare
8cd0505
to
5fac304
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work! I was able to manually test Container block transforms successfully. 🚀
72ba1f6
to
6d1997c
Compare
5fac304
to
412bd04
Compare
What?
Add integration tests to cover the block transform functionality of Container blocks.
Why?
This PR is a follow-up of #48792 to cover with tests the block transform functionality.
How?
Integration tests have been added to the following Container blocks:
Testing Instructions
Unit tests pass
Unit Tests / Mobile
job pass.Manual test
Follow the change introduced in #48792 that enables more block transforms, it would be great to test the transformations manually to confirm that work as expected.
NOTE: The web version usually displays more options because it supports more blocks. We should only check the supported blocks in the native version.
Here you can check the potential block transformations for the blocks
Columns
Group
dimRatio
attribute in order to enable this transformation.Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A