-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Show UI to update custom links on the sidebar navigation. #48939
Fix: Show UI to update custom links on the sidebar navigation. #48939
Conversation
Size Change: +296 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
e39ce7a
to
5de37ca
Compare
Flaky tests detected in 5619e75. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4562710990
|
d4b1701
to
66aed93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
66aed93
to
5619e75
Compare
Thank you for your tests @apeatling. Given that is not a big change and it is certainly better than what we have now where nothing happens, I will merge this PR. If anyone has any further feedback, we can iterate also, in case of an unexpected issue, it is ok to revert this PR. |
Fixes: #48593
This PR fixes a bug where it is not possible to change custom links on the sidebar navigation:
Testing Instructions
Add a custom link and verify it is possible to change its URL and label on the sidebar navigation.
Screenshot