Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 WIP: Use the style engine in global-styles 🚧 🧪 #48955

Draft
wants to merge 18 commits into
base: trunk
Choose a base branch
from
Draft

🚧 WIP: Use the style engine in global-styles 🚧 🧪 #48955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
280e649
Use the style engine for layout global styles
aristath Mar 9, 2023
e822be6
add a global rules_store to the object
aristath Mar 9, 2023
43cfe08
add get_css_variables_declarations method
aristath Mar 9, 2023
971c388
Use the style engine in get_root_layout_rules
aristath Mar 9, 2023
a4b1c82
remove unused parameter
aristath Mar 9, 2023
c3ceed5
add css variables to rules store
aristath Mar 9, 2023
9cdf338
transform get_layout_styles to add_layout_styles_to_rules_store
aristath Mar 9, 2023
c2ae51e
deprecate get_root_layout_styles
aristath Mar 9, 2023
262e325
more abstractions
aristath Mar 9, 2023
a5cb93b
deprecate compute_preset_classes
aristath Mar 9, 2023
4282695
minor fixes
aristath Mar 9, 2023
ac77124
convert add_root_layout_rules_declarations_to_rules_store method
aristath Mar 9, 2023
cf0254b
more tweaks
aristath Mar 9, 2023
f01ca92
Deprecate gutenberg_add_global_styles_for_blocks
aristath Mar 9, 2023
f3a69db
Allow the "display" property
aristath Mar 17, 2023
a1aceab
Add a $rules_store param in the constructor
aristath Mar 17, 2023
11536da
use the $rules_store param in tests
aristath Mar 17, 2023
c9aa11c
WIP - most tests are fixed
aristath Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions lib/block-supports/settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,8 @@ function _gutenberg_add_block_level_preset_styles( $pre_render, $block ) {
);
$theme_json_object = new WP_Theme_JSON_Gutenberg( $theme_json_shape );

$styles = '';

// include preset css variables declaration on the stylesheet.
$styles .= $theme_json_object->get_stylesheet(
$theme_json_object->add_stylesheet_to_rules_store(
array( 'variables' ),
null,
array(
Expand All @@ -116,7 +114,7 @@ function _gutenberg_add_block_level_preset_styles( $pre_render, $block ) {
);

// include preset css classes on the the stylesheet.
$styles .= $theme_json_object->get_stylesheet(
$theme_json_object->add_stylesheet_to_rules_store(
array( 'presets' ),
null,
array(
Expand All @@ -125,10 +123,6 @@ function _gutenberg_add_block_level_preset_styles( $pre_render, $block ) {
)
);

if ( ! empty( $styles ) ) {
gutenberg_enqueue_block_support_styles( $styles );
}

return null;
}

Expand Down
Loading