Add Script Versioning for Cache Busting #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
approved these changes
Apr 24, 2017
There was a problem hiding this comment.
Hey, this looks great and I'm fine to merge as-is.
One question: Do we want this to apply specific to the SCRIPT_DEBUG context? Or would you rather keep this as-is since we don't have a solution for the non-debug case (and I assume this would be addressed separately given discussion at #440).
|
Yes, we should address that once the build process provides separate files for development and production. |
|
Sounds good, thanks. |
|
I noticed today that we're missing versions for files enqueued during |
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds script versioning using
filemtime.