Fix misaligned textarea input control #49116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Bug
|
Size Change: +266 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Mar 16, 2023
I think perhaps there's an opportunity to improve that description (in a follow-up). How often are images purely decorative and shouldn't have alt text? |
Agree, here's an older tiny reduction I pondered:
I wonder if we could even do without the link. It seems an awkward way to have random external links in help text. To answer your question to the best of my understanding, though, images are very rarely decorative to the point that they need no description. Things like separators or backgrounds below text. But when they are decorative, it's important that the alt tag is empty, so we don't make a page overly verbose for a screen reader to read. |
richtabor
requested review from
spacedmonkey,
noahtallen,
ntwb,
nerrad,
ellatrix and
tellthemachines
as code owners
|
Flaky tests detected in 4264d2d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4461392032
|
Mamaduka
force-pushed
the
fix/textarea-input-block
branch
from
eaf34b7 to
0bc4d3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #49115 — although there may be a better way?
Why?
Consistency.
How?
Adds
display: blocktoinputControl, which removes the excess space that occurs after the textarea.Testing Instructions
Screenshots or screencast