Block Previews: Fix Duotone in Block Previews #49290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -5 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 21ec22c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4494913073
|
scruffian
added a commit
that referenced
this pull request
Mar 29, 2023
* Duotone: Pass filters to the Post Editor * remove whitespace change * remove whitespace change * Move SVGs into styles prop for EditorStyles * Handle duotone presets settings in add_editor_settings * Fix php lint * Add a check for $settings['styles'] to be safe * Use SVG component instead of svg * Use === instead of == * output the rules for all global styles not just the used ones * Block Previews: Fix Duotone in Block Previews (#49290) * Rename duotone css and svg variables * Move styles to the document.head with a portal This causes a flash of unstyled content, unfortunately. * Revert "Move styles to the document.head with a portal" This reverts commit 7d88a441db0142c97ca25cda0a17b424e263dd0d. * Move EditorStyles to body for EditorCanvas iframe * Move EditorStyles to body for the global styles StylesPreview iframe * Move EditorStyles to body for the StyleBook iframe * Refactor editorStyles for EditorCanvas * Directly test for css in the transformStyles call since that is what the function cares about * ?.length is unnecessary * Explain settings better * Partially revert "Refactor editorStyles for EditorCanvas" * Update useGlobalStylesOutput to use SVGs strings in styles instead of SVG elements in filterSvgs * Add missing __unstableType for svgs * Add comment about required JS changes for __unstableType in PHP --------- Co-authored-by: Alex Lende <alex@lende.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is built on top of #49239. This fixes block previews so that duotone filters work as expected.
Why?
Before this PR duotone wasn't working in block previews.
How?
Moves the EditorStyles component to the body of the iframe.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before:
After:
