Fix padding and margin visualizer accuracy #49422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the computed CSS value instead of the non-computed value - Add a small transition to smooth out the delay in resizing
talldan
added
[Type] Bug
|
Size Change: +37 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in cb0f4c0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4551002743
|
youknowriad
reviewed
Mar 29, 2023
| function getComputedCSS( element, property ) { | ||
| return element.ownerDocument.defaultView | ||
| .getComputedStyle( element ) | ||
| .getPropertyValue( property ); |
There was a problem hiding this comment.
So this function transforms the value to pixels or something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I've noticed on a few occasions that the padding and margin visualizers can be incorrect.
In #49392 (comment) I figured out why this is.
It happens for themes that use relative CSS units for spacing presets.
The visualizers are rendered in a popover slot, outside the editor canvas iframe. This means units like
vh,vw,remandemmight be computed incorrectly because they're using font size and the viewports size of the top level document, not those from the editor canvas document like the block uses.How?
There are two ways that I considered fixing this:
I went with option 2 because it's easier and seems to work correctly
Testing Instructions
Screenshots or screencast
Before
Kapture.2023-03-29.at.14.31.48.mp4
After
Kapture.2023-03-29.at.14.33.38.mp4