Icons: Update search icon to be optically more balanced. #49425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
Size Change: -137 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in fa8707a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4551592841
|
|
Good idea. It may not matter, but one observation is that this change would make the Search icon quite a bit smaller relative to others in the set. The new iteration is ~13 x 13 while others trend towards 16 x 16. This makes it look quite small in a lineup:
Again it might not matter, but the the balance may be improved if the handle was tilted exactly 45º instead of the current:
Feel free to discard, but I tried a different version, slightly larger, with a 45º handle:
|
|
Oh that's a good one, let me do a quick pass. |
|
How's this?
? |
|
That looks good tot me! |
jameskoster
approved these changes
Mar 29, 2023
|
Good stuff! |
bph
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The search icon was slightly right-heavy:
This PR nudges it a pixel, making it a bit more optically balanced:
Testing Instructions
Test that the appears looks as intended in storybook.