Add support for hiding breadcrumbs in the Site Editor #49518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Enhancement
|
Size Change: +235 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
talldan
reviewed
Apr 3, 2023
There was a problem hiding this comment.
Looks good. One final step would be to add a default value for this preference here:
gutenberg/packages/edit-site/src/index.js
Lines 62 to 70 in c60c26c
At the moment it'll be hidden by default once this PR is merged as the default is undefined. Even if it should stay hidden by default it'd be good to set an explicit false in the code above.
apeatling
reviewed
Apr 3, 2023
apeatling
approved these changes
Apr 3, 2023
Matches functionality of the post editor
|
Flaky tests detected in 83963cd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4602013788
|
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a preference to turn off block breadcrumbs within the footer of the Site Editor.
Why?
The Block Editor supports hiding of the block breadcrumbs; the Site Editor should as well.
How?
showBlockBreadcrumbsto the Site Editor Preferences panel.showBlockBreadcrumbsbefore rendering the breadcrumbs.Testing Instructions
Screenshots or screencast
CleanShot.2023-03-31.at.14.31.32.mp4