-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust copy of Site Logo Block #49540
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @masteradhoc! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
@masteradhoc Thanks for updating this. The changes here look good. There's one more step before this can be merged. Block descriptions are copied into from the block.json into some documentation. To make that happen, you can run You'll have to run edit: another much easier option if you don't have the repo checked out would be to update the docs by hand to match the block.json. The file that needs to be updated is |
@talldan thanks, done :)! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What? & Why?
Adjust the copy to remove duplicated content and be more consistent.
Fixes #49519
How?
The Term Graphic gets exchanged to Image
The Description gets cut a bit to remove the duplicated part and be more precise
Testing Instructions