Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust copy of Site Logo Block #49540

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Adjust copy of Site Logo Block #49540

merged 3 commits into from
Apr 12, 2023

Conversation

masteradhoc
Copy link
Contributor

What? & Why?

Adjust the copy to remove duplicated content and be more consistent.

Fixes #49519

How?

The Term Graphic gets exchanged to Image
The Description gets cut a bit to remove the duplicated part and be more precise

Testing Instructions

  1. Open a Page
  2. Insert a Site Logo Block
  3. Check the block description / copy

@masteradhoc masteradhoc requested a review from ajitbohra as a code owner April 2, 2023 20:58
@github-actions
Copy link

github-actions bot commented Apr 2, 2023

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @masteradhoc! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Apr 2, 2023
@talldan
Copy link
Contributor

talldan commented Apr 3, 2023

@masteradhoc Thanks for updating this. The changes here look good.

There's one more step before this can be merged. Block descriptions are copied into from the block.json into some documentation. To make that happen, you can run npm run docs:build in a local checkout of the repo.

You'll have to run npm i if you haven't installed the repo before.

edit: another much easier option if you don't have the repo checked out would be to update the docs by hand to match the block.json. The file that needs to be updated is /docs/reference-guides/core-blocks.md.

@masteradhoc
Copy link
Contributor Author

@talldan thanks, done :)!

@talldan talldan enabled auto-merge (squash) April 11, 2023 03:35
@t-hamano t-hamano self-requested a review April 12, 2023 16:14
@t-hamano t-hamano disabled auto-merge April 12, 2023 16:16
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think it's cleaner and very easy to understand.

Before

before

After

after

@t-hamano t-hamano added the [Block] Site Logo Affects the Site Logo Block label Apr 12, 2023
@t-hamano t-hamano merged commit d858c06 into WordPress:trunk Apr 12, 2023
@github-actions github-actions bot added this to the Gutenberg 15.7 milestone Apr 12, 2023
@masteradhoc masteradhoc deleted the patch-1 branch April 12, 2023 16:20
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Logo Affects the Site Logo Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Needs User Documentation Needs new user documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extraneous Site Logo block description
4 participants