[RNMobile] Add GlotPress project slug parameter to translations pipeline #49558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
the
Mobile App - i.e. Android or iOS
fluiddot
commented
Apr 3, 2023
| @@ -191,7 +191,7 @@ fi | |||
| # Define constants | |||
| SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd ) | |||
| GUTENBERG_SOURCE_CODE_DIR="$SCRIPT_DIR/../../.." | |||
| WP_CLI="php -d memory_limit=4G $SCRIPT_DIR/wp-cli.phar" | |||
| WP_CLI="php -d memory_limit=4G -d error_reporting=E_ALL&~E_DEPRECATED $SCRIPT_DIR/wp-cli.phar" | |||
There was a problem hiding this comment.
I noticed when using PHP 8.2.2 that WP-CLI displays logs about deprecated functions. Since this message doesn't provide helpful information for the purpose of the translation pipeline, I decided to filter them out.
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
|
Flaky tests detected in ce58b75. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4599207558
|
jhnstn
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Changes look good, tested via wordpress-mobile/gutenberg-mobile#5626
Nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add the GlotPress project slug parameter to the translation pipeline scripts.
Why?
Previously, the project slug was calculated based on the plugin's name. However, this is not always the case, so this will allow plugins to set their custom project slug if needed.
How?
The parameter has been added to the
i18n-translations-downloadscript and updated the logic accordingly.Testing Instructions
Follow testing instructions from GB-mobile PR.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A