-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image: Display custom borders on placeholder #49569
Image: Display custom borders on placeholder #49569
Conversation
Size Change: +440 B (0%) Total Size: 1.35 MB
ℹ️ View Unchanged
|
Flaky tests detected in 6c2ad77. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4613608871
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Followed the instructions and everything checked out and worked as expected.
Global styles set border on deselected image, and not on selected image with placeholder:
Custom border set on image shown when deselected, and not when selected:
Global styles based and block custom border working correctly when image set:
Fixes: #49144
Related:
What?
Applies custom borders from either Global Styles or individual border block supports to the Image block's placeholder when it isn't selected.
Why?
This brings the Image block more in line with the Post Featured Image block which displays borders on its placeholder.
How?
Testing Instructions
Screenshots or screencast
Screen.Recording.2023-04-04.at.6.15.25.pm.mp4