Refactor the effects panel as a generic UI Styles component #49571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
youknowriad
requested review from
oandregal,
madhusudhand,
andrewserong,
ntsekouras and
aaronrobertshaw
|
Size Change: +1.01 kB (0%) Total Size: 1.35 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c7125e3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4616471688
|
aaronrobertshaw
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
This is testing well for me.
✅ Effects panel shows correctly in Global Styles (Button block only)
✅ Effects panel is not present for individual Button blocks
✅ Shadows continued to function correctly in both editor and frontend
Nice work as always @youknowriad 🙇
There's a minor copy-and-paste issue we can clean up but other than that I think this is good to go.
packages/block-editor/src/components/global-styles/effects-panel.js
Outdated
Show resolved
Hide resolved
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this discussion #37064
This is also a prerequisite to #49428
What?
To unify the block sidebars between the global context (global styles) and the local context (block inspector), we're refactoring the global styles panels to use the same components between these two context. While the "effects panel" (shadow) is not available yet at the local level, there's no reason for its code to be different than the others and this also makes it easy to add it to the block level later on.
Testing Instructions
This is just a refactoring PR so just ensure that the "effects" (shadow) panel within the global styles of the "button" block (the only block that supports shadow so far) works as expected.