Style Variation picker: restore pointer cursor when withHover is in use #49596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Regression
|
Size Change: +15 B (0%) Total Size: 1.35 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in eae071a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4614234223
|
|
Can
|
Unfortunately, that doesn't appear to work for this case. This component is a little tricky: Usually, we'd set
Conversely, if we use the
So, I think all that means that we need to fix this within the iframe.
I agree. Since it appears that we need to do set the |
talldan
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Unfortunately, that doesn't appear to work for this case.
That's a shame.
I agree. Since it appears that we need to do set the cursor within the iframe, what do you think about adding an isButton prop so that we have clearer semantics?
That does sound like it'll make the component become a button.
Let's go with what you have here for now if there's no easy option.
Thank you for spotting the regression and fixing it.
Yes, I was hoping for a quick CSS fix, too! 😅
Thanks for reviewing and for the back-and-forth, happy to look into a follow-up if it winds up looking like we want a more explicit fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In #49573 the
cursor: pointerrule was removed from the style variation preview, so that it doesn't appear to be clickable from the styles panel. However it looks like that removal might have unintentionally removed the rule from the button previews for the style variations in theBrowse stylesscreen.This PR restores the
cursor: pointerrule when thewithHoveroption is in use for the preview — the assumption being that if we're using the hover state, we're also using the preview as a button.Why?
Ensure that the button version of the style variation previews are clickable. The rule needs to be set within the iframe for it to work.
How?
withHoveris in use.Question: is it okay to tie this rule to
withHover, or should we be more explicit with an additionalisButtonprop or something like that? I tried fixing this by settingcursor: pointerfurther up the chain, but it looks like it needs to be set within the iframe.Testing Instructions
Screenshots or screencast