-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a UI to allow saving patterns #49607
Conversation
Size Change: +53 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
Flaky tests detected in eb29d2b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4636885831
|
e27e34a
to
17e2e0f
Compare
I was trying to decipher what this PR is all about, and then I found this comment from @carolinan in #33094:
This is very interesting when it eventually combines with the planned work on This is going to be interesting to see how the concept of Reusable blocks morphs into Synced Patterns managed by sites, making them capable of fulfilling many of the needs that lead today creating custom blocks. |
Yeah, it's basically trying to allow users to create and save patterns - just like they do for reusable blocks... |
I know this PR is not ready for testing yet, but I couldn't help myself 😅 Excellent work so far. I'm looking forward to seeing how this evolves! |
Awesome exploration! The main implementation aspect that I'd like to revise is that of using a separate post type. This is a great opportunity to coalesce on how we are storing user reusable content (see #34352 and #41717). So I'd love to see if we can incorporate into the exploration the idea of using
Sync status can either be a meta value of the post type or an aspect of the insertion (full sync and partial sync would exist as |
This reverts commit 355b4f3.
should this be closed as it was implemented here: #51144? |
Props @mykola @janw-me @hdvos @rolf-yoast @enricobattocchi @aristath @carolinan @SergeyBiryukov @mhkuu @afercia during a Yoast contributor day on April 5, 2023
What?
This PR adds a UI to allow users to save and edit patterns in the editor.
The UI is identical to that of reusable-blocks.
Why?
Right now patterns can only be created programmatically, and there have been numerous requests to allow users to create and edit their own patterns.
How?
Duplicating the functionality of reusable blocks.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast