Make InspectorControls tab labels translatable #49665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
the
Internationalization (i18n)
|
Size Change: -3 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8155917. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4639700955
|
aaronrobertshaw
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the problem of InsepcotrControls tab titles not being translated.
How?
Applied
__()function to the title property.Testing Instructions
My understanding is that if the same text exists in the JavaScript code with the translation function applied, and it is translated by GlotPress, it will be translated immediately.
However, if I change the language of the site and update the translation files, somehow only "Styles" is translated.
If anyone knows any reason for this, I would love to know.
"List View" label:
"Settings" label:
"Styles" label: