WIP: Fix flaky Site Editor writing flow tests #49754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -43 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f15b795. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4678658140
|
|
I noticed that tests fail locally with the @kevin940726, I found a workaround by using |
kevin940726
reviewed
Apr 13, 2023
| await editor.canvas.click( 'body' ); | ||
|
|
||
| // Wait for the template part to be loaded. | ||
| await page.waitForLoadState( 'networkidle' ); |
There was a problem hiding this comment.
Wild idea: How about adding this to visitSiteEditor so that we solve all the site editor flakiness automatically? 😅
There was a problem hiding this comment.
Oh, this gives me some ideas. I'll update in #49374.
There was a problem hiding this comment.
We can also update visitSiteEditor and visitAdminPage to accept options passed to page.goto - https://playwright.dev/docs/api/class-page#page-goto-option-url.
|
Closing this in favor of #49374. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
🚧
See: #48504, #49025
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast