[RNMobile] Listen for post save events #49781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiobhyB
added
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
|
Flaky tests detected in daf06a3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4724789534
|
4 tasks
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
Gutenberg Mobile: [RNMobile] Listen for post save events wordpress-mobile/gutenberg-mobile#5663iOS: [Gutenberg] Emit editor save events wordpress-mobile/WordPress-iOS#20522Android: [Gutenberg] Emit editor save events wordpress-mobile/WordPress-Android#18279What?
The changes in this PR introduce a way for Gutenberg Mobile to detect post save events that are emitted from the native apps.
Why?
There isn't currently a built-in way to detect when a post has been recently saved on native, which would be useful for certain functionality or blocks.
How?
For now, a
postHasBeenJustSavedevent is being emitted from the Android and iOS apps when a post is manually saved by a user. Different blocks are then able to set up an event listener. An example implementation can be found in Automattic/jetpack#30131.This PR focuses on creating an optional way to detect save events, but it could potentially serve as a base for linking up to Gutenberg's
isSavingPostselector.Testing Instructions
With this branch applied, follow these steps in both the Android and iOS apps: