Adds PHPUnit tests for gutenberg_register_fonts_from_theme_json(). #49877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellofromtonya
added
[Feature] Fonts API
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
hellofromtonya
force-pushed
the
add/gutenberg_register_fonts_from_theme_json-tests
branch
2 times, most recently
from
c86b659 to
c686fc0
Compare
hellofromtonya
force-pushed
the
add/gutenberg_register_fonts_from_theme_json-tests
branch
from
c686fc0 to
ce852de
Compare
|
Flaky tests detected in ce852de. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4737254870
|
|
Thank you for reviewing @anton-vlasenko 😃 I've committed both of your typo fixes - thank you - as well as left the reasoning for why |
hellofromtonya
force-pushed
the
add/gutenberg_register_fonts_from_theme_json-tests
branch
from
cea3524 to
aeedd6d
Compare
anton-vlasenko
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Thank you for the quick reply, @hellofromtonya.
I was not able to find anything except the typos I mentioned.
The code looks good to me 👍
Therefore, I approved the PR.
hellofromtonya
deleted the
add/gutenberg_register_fonts_from_theme_json-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adding PHPUnit tests for
gutenberg_register_fonts_from_theme_json().Why?
theme.jsonand style variation fonts and variations.How?
Adds a theme with fonts defined in its
theme.jsonand a mixture of scenarios in its style variations.Adds a test class for this function with the following coverage:
theme.jsonand style variations.variations-duplicate-fontsstyle variation includes with duplicate DM Sans variations.srcfile:./into a URL to the font's asset file.fontFamilyintofont-family.fontFaceis not defined.Missing test coverage
Testing the variation font-family handle logic is missing from this PR. Why? There's possibly a flaw in the logic that needs investigation. This makes it out-of-scope for this PR.
Testing Instructions
CI is green.
Manual