-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List View: Add aria-description #49907
Conversation
Size Change: +10 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
I'll just add @alexstine as a reviewer here since there was recently some detailed work that landed in #48461 to refactor the ARIA props for the list view to ensure they're all optimised for screen readers. It'd be good to make sure this doesn't adversely affect anything that was recently updated there. From a quick skim, this change sounds good to me, though, since it's only updating at the very root / container of the list view 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this should be fine.
Thanks for the quick review, Alex! |
Thanks for the quick review and merge here! |
What?
This adds an
aria-description
attribute to the list view.Why?
This came up as part of the accessibility review for the off canvas editor component, and the attribute was added there, but not ported back to the list view, so this PR takes care of that.
How?
Add a new prop (another one!) to the list view to populate the attribute, if its set.
Testing Instructions
Testing Instructions for Keyboard
This should be useful for screen readers, but I'm not totally sure how the aria-description attribute gets read.
Screenshots or screencast