Cover: Reduce z-index for inner blocks container #49943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
andrewserong
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Thanks for the quick fix @aaronrobertshaw!
This is all testing nicely and fixes the bug for me:
2023-04-20.11.46.28.mp4
✅ Placeholder state buttons all work correctly
✅ Borders still behave as on trunk
✅ Child blocks are still selectable while the Cover block is selected
LGTM! ✨
|
Size Change: -12 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Apr 20, 2023
Copilot was dreaming, I might remove that part of the summary to avoid confusion down the line. |
|
Flaky tests detected in f13811b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4749612383
|
andrewserong
added
the
Backport to Gutenberg Minor Release
andrewserong
pushed a commit
that referenced
this pull request
Apr 20, 2023
andrewserong
removed
the
Backport to Gutenberg Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #49939
What?
Restores the original z-index style values for the Cover block's inner blocks container.
🤖 Generated by Copilot at cfec9b3
Reduced z-index values for cover block elements in
_z-index.scssto prevent overlaps with other block editor elements.🤖 Generated by Copilot at cfec9b3
Why?
The higher z-index caused the inner blocks to appear above things like sticky groups, headers, etc.
How?
The need for the higher z-index was already solved via disabling pointer events on the main block popover container and reenabling them on the child drag handle. This meant the z-index changes that landed in #41153 were no longer required.
Testing Instructions
Screenshots or screencast
Screen.Recording.2023-04-20.at.11.36.52.am.mp4