Global styles revisions: remove human time diff and custom author fields from the API response

[ramonjd]

What?

Like it says in the title, this PR removes the human friendly time diff ('date_display') and custom author fields ('author_display_name' and 'author_avatar_url')

Why, for the love of all that is pure and innocent?!

To make the response appear a little closer to the regular post revisions object.

The assumption is that the consumer can format the raw dates and grab user information as they wish.

Pursuant to the last point, there's a humanTimeDiff JS function in the works that will take care of this. and, furthermore, we can match revision authors on the frontend using the response from getUsers.

See #50089 for context

How?

Liberal use of my keyboard's delete key, which now has dried pasta sauce on it because I didn't wipe my fingers properly after lunch. I am not a monster!

Testing Instructions

Run the tests!

npm run test:unit:php -- --filter Gutenberg_REST_Global_Styles_Revisions_Controller_Test

You can also check the response in the console. Make sure you're in the site editor and your global styles have a few revisions already.

await wp.apiFetch( { url: `/index.php?rest_route=%2Fwp%2Fv2%2Fglobal-styles%2F${ wp.data.select('core').__experimentalGetCurrentGlobalStylesId() }%2Frevisions&_locale=user` } );

date_display, author_display_name and author_avatar_url should no longer appear in the response objects

[andrewserong]

Thanks for the update, this makes for a much leaner response when there's heaps of revisions, too 👍

✅ Response has the expected fields, with the no longer needed ones removed
✅ An OPTIONS request returns the correct fields in the schema, tested by running:

await wp.apiFetch( { method: 'OPTIONS', url: `/index.php?rest_route=%2Fwp%2Fv2%2Fglobal-styles%2F${ wp.data.select('core').__experimentalGetCurrentGlobalStylesId() }%2Frevisions&_locale=user` } );

See #49050 for context

Do you mean #50089 😄

Liberal use of my keyboard's delete key, which now has dried pasta sauce on it because I didn't wipe my fingers properly after lunch. I am not a monster!

That's okay, my keyboard has pumpkin on it now because I also forgot to wash my hands after chopping veggies for the soup I made. Lesson learnt!

LGTM ✨

[ramonjd]

Do you mean #50089 😄

Hah, I can't even manage my clipboard history. I'll update the description to save me embarrassment in case anyone comes back to this.

Thank you for testing!

[noisysocks]

Were there any backwards compatibility concerns here?

[andrewserong]

Were there any backwards compatibility concerns here?

No, I don't think so. The endpoint was only added last week in #49974 and isn't being used anywhere yet.

[ramonjd]

Were there any backwards compatibility concerns here?

Thanks for raising it. What @andrewserong said.

That's part of the reason why I pared the API response back so much in this PR - there wasn't a very strong use case for these properties and I thought it best to remove them to avoid backwards compatibility issues later. Or laterz. Whichever you prefer 🛹

[noisysocks]

All good just double checking 😀