Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme Previews: Fix refactor #50354

Merged
merged 1 commit into from
May 4, 2023
Merged

Theme Previews: Fix refactor #50354

merged 1 commit into from
May 4, 2023

Conversation

scruffian
Copy link
Contributor

@scruffian scruffian commented May 4, 2023 •
edited
Loading

What?

I refactored this code in #50338 but missed a function name change. This finishes the refactor properly

Why?

wp-admin/themes.php is throwing a fatal on trunk.

How?

Rename the function and then reorganise the code so it behaves the same as before.

Testing Instructions

  1. Go to wp-admin/themes.php and confirm you don't see a fatal error
  2. Preview a block theme
  3. Activate it from the site editor
  4. Confirm that the activation works correctly

@scruffian scruffian requested a review from spacedmonkey as a code owner May 4, 2023 22:28
@scruffian scruffian self-assigned this May 4, 2023
ajlende
ajlende approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@ajlende ajlende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@scruffian scruffian enabled auto-merge (squash) May 4, 2023 22:35
@scruffian scruffian merged commit 516201e into trunk May 4, 2023
@scruffian scruffian deleted the fix/theme-preview-refactor branch May 4, 2023 22:55
@github-actions github-actions bot added this to the Gutenberg 15.8 milestone May 4, 2023
@bph bph added [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Bug An existing feature does not function as intended labels May 8, 2023
@bph bph mentioned this pull request May 8, 2023
Closed
23 tasks
@ramonjd ramonjd mentioned this pull request Jun 5, 2023
Closed
@ramonjd ramonjd added the Needs PHP backport Needs PHP backport to Core label Jun 5, 2023
@MaggieCabrera MaggieCabrera mentioned this pull request Jun 16, 2023
Closed
8 tasks
@ramonjd ramonjd removed the Needs PHP backport Needs PHP backport to Core label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajlende ajlende ajlende approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees

@scruffian scruffian

Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 15.8
Development

Successfully merging this pull request may close these issues.
4 participants
@scruffian @ajlende @bph @ramonjd