-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Add testID
prop to SandBox component
#50399
[RNMobile] Add testID
prop to SandBox component
#50399
Conversation
Size Change: 0 B Total Size: 1.38 MB ℹ️ View Unchanged
|
Flaky tests detected in 3c72d13. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4917633397
|
c6c852e
to
ea21fd8
Compare
282da7c
to
3c72d13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests passed per wordpress-mobile/gutenberg-mobile#5735
Nice work!
* Update setup media picker helper to handle single and multiple items * Include `metadata` param when notifying succeed state in `setupMediaUpload` helper * [RNMobile] Add `testID` prop to SandBox component (#50399)
What?
Pass
testID
prop to the SandBox component.Why?
This is needed for tests being worked on Gutenberg Mobile: wordpress-mobile/gutenberg-mobile#5734.
How?
Add
testID
prop.Testing Instructions
These changes can be tested via wordpress-mobile/gutenberg-mobile#5735. Specifically, this change is used here.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A