List View: Update the expanded text color so that it works in both a dark and light context #50434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dark and light context
scruffian
added
the
[Feature] List View
|
Size Change: 0 B Total Size: 1.38 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 6431413. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4916070317
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the CSS for list view so that the overrides for button colors works in both a light and dark context.
Why?
This is needed that the list view can work in the browse mode sidebar as well as the regular canvas.
How?
This line of CSS makes these buttons blue by default:
List view already has an override for this to make it grey, but we can change that to just inherit from the wider context, which means that it will use whatever color the rest of the text is.
Testing Instructions
Testing Instructions for Keyboard
As above
Screenshots or screencast