support searching pages #50645
Closed
support searching pages #50645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
We already support searching pages without this PR |
|
The boolean you changed indicates whether a post type has a REST API that supports searching or not. If the API doesn't support searching like "template" and "template part" we only rely on local search since the REST API retrieves all the entries and this is not how the "page" REST API works. |
|
@youknowriad weird, page searching isn't working for me on |
|
The difference is probably the following:
There might be a bug in trunk though that hides "valid" results in some occasions though. |
|
That makes sense, thanks @youknowriad . It takes maybe 3-4 seconds with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds ability to search and edit pages in the site editor via the command menu.
Why?
We are re-introducing content editing in the site editor which means it may also be a good time to allow searching for pages via command center.