Template revisions: require 2 revisions before showing the revisions UI #50762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k. Removing the `+ 1` ensures this.
ramonjd
added
[Type] Bug
|
Size Change: -5 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 62058ea. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5019984469
|
apeatling
approved these changes
May 19, 2023
|
Thank you for fixing this in the UI @ramonjd 🙏🏻 As you mentioned it's a partial fix - we should still aim to fix this so that after 1 change users get the button saying "1 revision". I think this system of loading the file in the DB needsa bit of tweaking in terms of when the "loading" happens. Not it only happens when we edit, but maybe it should be loaded when it's 1st opened? |
Good point, thanks for sharing @draganescu It sounds like a tricky one to solve. I tried to find a place in the code to try it out, but got a bit stuck and spent too much time on it 😄 What would we class as "first opened"?
I'm guessing the first option might be better? If we detect that the template record doesn't exist we can create a new one in the database. I admit I did hack around to create a POC but couldn't come up with the right way to interact with the entityRecords. Note, this problem doesn't appear to affect custom template, since a database record is inserted as soon as the custom template is created, and every modification thereafter is a "revision". Edit: this is in the context of the WordPress code diff revisions.php page. I suppose we could manipulate the "first" revision if we developed an in-editor revisions UI like we have done for the global styles. |
Yes if that's the path I guess we should not do anything and wait. Not sure.
The templates API endpoint calls |
This was referenced Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #50675 (at least partially)
What?
We want to have at least 2 revisions before showing the revisions UI for templates and template parts.
Why?
Quoting @talldan from #50675 (comment)
Because of this, it takes another 2 edits to create 2 "revisions". Without that crucial second edit the revisions UI will not display an empty pane as it has nothing with which to compare the first.
How?
Removing the
+ 1on the revisions count.Testing Instructions
In the site editor, make three changes to a template.
The revisions button should display.
Now check out the revisions UI and ensure that there is no blank revision on the right hand side.
Repeat for a template part.
cc @georgeh for review as well
Screenshots or screencast
2023-05-19.11.47.00.mp4