Pattern: Experiment with using template slots for content replacement #50777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Status] In Progress
|
Size Change: -1.16 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
gziolo
force-pushed
the
try/pattern-template-slot
branch
from
6ff975d to
f76a7f6
Compare
talldan
reviewed
May 24, 2023
| '', | ||
| array( | ||
| '<!-- wp:paragraph {"fontSize":"huge"} -->', | ||
| '<p class="has-huge-font-size"></$wp:template-content name="getInTouch"></p>', |
There was a problem hiding this comment.
Is the / in the right place for $wp:template-content?
There was a problem hiding this comment.
I was experimenting with the idea of the tag closer that gets converted to the HTML comment in the browser. In effect, if you never replace </$wp:template-content name="getInTouch"> with the content, the block will still get rendered correctly for the site editors because it will simply skip this syntax for the content placeholder.
@dmsnell came up with the idea of using something like </$wp:template-content>. The interesting aspect of it is that it can be matched with the HTML tag processor when visiting closing HTML tags.
This was referenced May 24, 2023
|
As noted in #50649 (comment), I started implementing the concept of converting all template content data into virtual blocks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Exploring ideas shared by @dmsnell in #50456 (comment).
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast