Revert "Browse Mode: Add snackbar notices (#50794)" #50937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a2d8295.
talldan
added
[Feature] Blocks
andrewserong
added
the
Backport to Gutenberg RC
andrewserong
approved these changes
May 25, 2023
There was a problem hiding this comment.
Thanks for opening up the revert. It was a cool feature enabling the snackbars in browse mode, but it'd be good to get this revert merged to fix up the regressions for 15.9, before having another go at it.
I've re-tested, and this appears to fix both the blurriness issue, and the positioning of the block toolbars. LGTM!
|
Size Change: +43 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1635871. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5076118689
|
|
@c4rl0sbr4v0 just checking, are you running the GB 15.9 release? If so, would you mind cherry-picking this PR into the release? If not, I'm happy to cherry-pick into the release branch. It'd be good to ensure this fix makes it in 🙂 |
|
Cherry picked to |
luisherranz
added
Backport to Gutenberg RC
cbravobernal
removed
the
Backport to Gutenberg RC
|
@luisherranz You add the label Backport to Gutenberg RC. Then you cherry pick. Once is cherry picked, you can remove it. There is also a script that makes all of this automatically: |
|
My mistake, sorry. I wanted to add it to this PR instead. |
|
Hi there! I wanted to note that the problem at the time this PR was submitted seems to have been solved by the merge of #51054. (c.f. #50175 (comment)) |
|
Thanks for taking care of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As mentioned in #50794 (comment), this causes quite a bad bug with block toolbars, so I think a revert is best for now.
Why?
I'm not sure why the bug happens.
The change to
scalemight explain the blur, but I'm not sure on the rest of it.How?
git revertTesting Instructions
Screenshots or screencast
Before
After
Kapture.2023-05-25.at.12.32.41.mp4