-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Update icon for UngroupButton component #50969
Conversation
Size Change: +2.47 kB (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
Flaky tests detected in 66d88f6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5081081863
|
packages/block-editor/src/components/ungroup-button/index.native.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊 ! Thanks @t-hamano for updating this 🙇 !
I confirmed the Ungroup icon is displayed by using the Group block. Note that the icon changed:
Before | After |
---|---|
Tested on Simulator - iPhone 14 (iOS 16.0)
Thanks for the review, @fluiddot! |
Part of #50520
Related to #17575
What?
This PR updates the ungroup icon that appears on the toolbar at the bottom of the screen.
Why?
This icon was hard-coded SVG. However, an icon representing the same meaning already exists in the
icons
package, so I thought it made sense to use it.Testing Instructions
I am a Windows user and tried to debug using Android Studio, but I just could not get the emulator to work properly.
The following icon should appear instead:
I apologize for not being able to test this, but I would appreciate it if you could check to see if this change makes sense.