-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separate template screens site editor #51040
Conversation
Size Change: +196 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
Flaky tests detected in 0c0aa7f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5128847443
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the PR manually and I do not see any issues or breaking changes with the screens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also tested and seems to work fine.
Relaunched the failing tests before diving further.
* separate template and template part screens site editor
What?
We currently have one file that manages both templates and template part detail pages. This PR splits them out so they each have their own page.
Why?
As we start to extend these two pages (templates and parts) they will begin to diverge and managing that divergence in the one file will get complicated.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast