[RNMobile] Avoid "429 - Too Many Request" error when fetching translations #51103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
|
Flaky tests detected in dafdad0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5123638761
|
I noticed when testing that requests to the language URL were being redirected. For this reason, the URL has been updated to avoid this redirection.
fluiddot
commented
May 31, 2023
| const getLanguageUrl = ( locale, projectSlug ) => | ||
| `https://translate.wordpress.org/projects/${ projectSlug }/dev/${ locale }/default/export-translations\?format\=json`; | ||
| `https://translate.wordpress.org/projects/${ projectSlug }/dev/${ locale }/default/export-translations/\?format\=json`; |
There was a problem hiding this comment.
I noticed when testing that requests to the language URL were being redirected. For this reason, the URL has been updated to avoid this redirection.
Merged
2 tasks
geriux
approved these changes
Jun 1, 2023
fluiddot
deleted the
rnmobile/fix/fetch-translations-too-many-requests-error
branch
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…tions (WordPress#51103) * Fetch translations in batches * Abort fetch translations process upon failure * Avoid parsing response if translation request failed * Retry translation download when getting error 429 * Revert fetch translations in batches * Fix language URL I noticed when testing that requests to the language URL were being redirected. For this reason, the URL has been updated to avoid this redirection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
bundle:jscommand is not executed ifcleanfails wordpress-mobile/gutenberg-mobile#5820What?
Update the script for downloading the translations to avoid the "429 - Too Many Request" error.
Why?
I recently experienced errors when downloading translations as part of React Native bundle generation. We need to ensure that translations are downloaded to include them in the bundle.
How?
Testing Instructions
npm run native i18n:fetch-translationsmultiple times. This can be tested with the following command:Translation file <URL> for project slug wp-plugins/gutenberg failed with error 429 - Too Many Requests, retrying (5)....packages/react-native-editor/i18n-cache/gutenberg/data.Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A