-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide the save draft button for published posts #51193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
An existing feature does not function as intended
[Feature] Saving
Related to saving functionality
labels
Jun 2, 2023
jasmussen
approved these changes
Jun 2, 2023
Size Change: +16 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
Flaky tests detected in deaa32d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5153502404
|
mtias
approved these changes
Jun 2, 2023
artemiomorales
pushed a commit
to artemiomorales/gutenberg
that referenced
this pull request
Jun 2, 2023
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Saving
Related to saving functionality
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #50217
What?
This fixes a small regression introduced in #50217 where a "save draft" button started to appear in the top toolbar of the post editor for published posts.
How?
The switch to draft button has been removed from the toolbar, but it shouldn't be replaced by the "save draft" button.
Testing Instructions
1- Publish a post
2- No "save draft" button should appear in the top toolbar of the post editor.