Update the bottom sticky section in the site editor details panel #51274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
the
[Feature] Site Editor
jameskoster
commented
Jun 6, 2023
| border-top: 1px solid $gray-800; | ||
| box-shadow: 0 #{-$grid-unit-10} $grid-unit-20 $gray-900; |
There was a problem hiding this comment.
I can take or leave the shadow. I added it to be consistent with the panel header, but would just as happily remove it in both instances.
There was a problem hiding this comment.
I think we can remove this as part of the scroll behaviour issue in a follow up.
|
Size Change: +5 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
SaxonF
approved these changes
Jun 7, 2023
| border-top: 1px solid $gray-800; | ||
| box-shadow: 0 #{-$grid-unit-10} $grid-unit-20 $gray-900; |
There was a problem hiding this comment.
I think we can remove this as part of the scroll behaviour issue in a follow up.
43 tasks
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates some appearance details of the bottom sticky section in the site editor details panel
Why?
The width / spacing of menu items therein are not currently consistent with other similar items outside the sticky area.
It's currently possible to hover menu items that are 'behind' the sticky area.
Scrolling is currently a bit strange – the sticky area feels partially unstuck when you reach the bottom of the panel.
Before
before.mp4
After
after.mp4