Fix invalid Spacer markup when set to fill #51317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.02 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
tellthemachines
added
[Type] Bug
ramonjd
approved these changes
Jun 13, 2023
Co-authored-by: Ramon <ramonjd@users.noreply.github.com>
|
Thanks for reviewing @ramonjd ! |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Fix invalid Spacer markup when set to fill * Try unsetting default height in save * Update comment Co-authored-by: Ramon <ramonjd@users.noreply.github.com> --------- Co-authored-by: Ramon <ramonjd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #51235.
When spacer block is in vertical mode, inside a flex container (e.g a Stack block) and set to "fill" or "fit", the block markup is flagged as invalid due to a missing height attribute. This fixes the issue by making sure the default height value doesn't automatically get added in the save function if the block is in a flex container and set to "fit" or "fill".
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast