Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageContent: Fix unlock import #51360

Merged

Conversation

andrewserong
Copy link
Contributor

@andrewserong andrewserong commented Jun 9, 2023

What?

A small follow-up to #51281 and #51322 to fix up an import so that unlock is imported from the correct location.

Why?

The above two PRs were merged in quick succession, so unfortunately this import was missed.

How?

Update the import line for the PageContent component, so that it imports from lock-unlock as in #51322.

Testing Instructions

  • Check that the static analysis / linting jobs pass
  • To be thorough, open up the site editor browse mode, select Pages, and click to edit a page in your site
  • In the right-hand sidebar, you should see the block quick navigation

Screenshots or screencast

This is the component that should still be rendering correctly:

image

@andrewserong andrewserong added [Type] Code Quality Issues or PRs that relate to code quality [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jun 9, 2023
@andrewserong andrewserong requested a review from noisysocks June 9, 2023 02:38
@andrewserong andrewserong self-assigned this Jun 9, 2023
Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andrewserong andrewserong enabled auto-merge (squash) June 9, 2023 02:52
@andrewserong
Copy link
Contributor Author

andrewserong commented Jun 9, 2023

Thanks for the review! The Performance Tests action appears to be failing because it can't be built in trunk:

image

I think we might need to manually merge this one while skipping the Performance tests if anyone has access to merge this in?

@noisysocks noisysocks disabled auto-merge June 9, 2023 03:17
@noisysocks noisysocks merged commit 291a195 into trunk Jun 9, 2023
@noisysocks noisysocks deleted the fix/unlock-import-in-page-panels-page-content-component branch June 9, 2023 03:17
@github-actions github-actions bot added this to the Gutenberg 16.1 milestone Jun 9, 2023
@noisysocks
Copy link
Member

Ugh, sorry about that, thanks for fixing!

@andrewserong
Copy link
Contributor Author

No worries, thanks for merging! 🎉

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Flaky tests detected in 59d2793.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5217670474
📝 Reported issues:

sethrubenstein pushed a commit to pewresearch/gutenberg that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants