Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML-API: Backport updates from Core #51416

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

dmsnell
Copy link
Member

@dmsnell dmsnell commented Jun 12, 2023

What?

This is a "blessed" PR, bringing back changes that were introduced to the HTML API in Trac/SVG that need to exist in Gutenberg to avoid introducing breakage and disharmony between the two repositories.

Notes

  • this patch restores 6.2 files which were erroneously updated with backports from trunk. now the compat/wordpress-6.2 directory mirrors the HTML API as currently found in the 6.2 branch of WordPress-develop
  • while all of the HTML API classes were modified in WordPress-develop/trunk only the Tag Processor itself has been brought over, because the other files only involve docblock changes, not behavioral changes, and bringing them over also would require renaming everything inside the Tag Processor to use the Gutenberg_..._6_3-wrapped versions of those classes.

Why?

This is part of a normal process, whereby any updates to SVN need to be back-ported into Gutenberg.

How?

  • Copy updates from WordPress-develop repo into Gutenberg repo
    • from WordPress-develop/6.2 copy all files into lib/compat/wordpress-6.2/html-api/
    • from WordPress-develop/trunk copy just the tag processor into lib/compat/wordpress-6.3/html-api
  • Manually verify that the Gutenberg_..._6_3 class name remains in the 6.3 compat layer instead of the WP_... name.

Testing

Since these tests are already reviewed, tested, and merged into Core, they do not need additional review here. Please ensure that the test suite passes and that nothing was overlooked in the backport process, something which could lead to obvious and catastrophic breakage.

cc: @SergeyBiryukov (any changes in Trac/SVN need to have a corresponding PR here like this one, which incorporates the changes you applied).

@dmsnell dmsnell requested review from ockham and SergeyBiryukov June 12, 2023 11:57
@dmsnell dmsnell requested a review from spacedmonkey as a code owner June 12, 2023 11:57
@dmsnell dmsnell marked this pull request as draft June 12, 2023 12:17
@WordPress WordPress deleted a comment from github-actions bot Jun 12, 2023
@dmsnell dmsnell force-pushed the html-api/backport-updates-from-core branch from 735cbd4 to eec2470 Compare June 12, 2023 12:58
@dmsnell dmsnell marked this pull request as ready for review June 12, 2023 13:04
@WordPress WordPress deleted a comment from github-actions bot Jun 12, 2023
Copy link
Member

@SergeyBiryukov SergeyBiryukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing over these changes from core! Looks good to me 👍

SergeyBiryukov

This comment was marked as duplicate.

@dmsnell
Copy link
Member Author

dmsnell commented Jun 13, 2023

@hellofromtonya looks like we have another defect in the linting here, as it's blocking this PR, which is code already accepted and merged in Core. I'd like to merge this, but I don't like that we have a rejected CI stage.

Seems like this happens almost every time we backport code from Core. Is someone working on addressing these problems?

@dmsnell dmsnell force-pushed the html-api/backport-updates-from-core branch 3 times, most recently from 270d4ea to 410074f Compare June 19, 2023 10:23
This is a "blessed" PR, bringing back changes that were introduced to the HTML API
in Trac/SVG that need to exist in Gutenberg to avoid introducing breakage and
disharmony between the two repositories.

cc: @SergeyBiryukov
@dmsnell dmsnell force-pushed the html-api/backport-updates-from-core branch from 410074f to a40838d Compare June 19, 2023 11:22
@dmsnell dmsnell merged commit a40838d into trunk Jun 19, 2023
@dmsnell dmsnell deleted the html-api/backport-updates-from-core branch June 19, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants