Refactor Site Editor block editor code #51524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Code Quality
|
Note that the parent PR already under went technical review by @youknowriad so I'm pretty confident this is 👍 |
|
Size Change: +648 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
scruffian
reviewed
Jun 15, 2023
packages/edit-site/src/components/block-editor/providers/default-block-editor-provider.js
Show resolved
Hide resolved
|
There's likely more work to do but at least the core of the refactor can land. |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Refactor Site Editor code * Naming consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Sub PR of #39286.
Pulls out the changes made in the above PR to improve the code organisation of the block editor section of the Site Editor.
Why?
The code was not open to extension and required refactoring to allow for the (possible) introduction of Navigation Focus Mode.
As that PR does not seem to have a consensus I'm raising this one so we can land the Site Editor refactor separately as it has merit in its own right.
How?
Reorganises and refactors the code to be more open to changes.
Testing Instructions
Test that the Site Editor behaves as per
trunk.Check that when you load the Site Editor you can still browse and edit Templates, Template Parts, Reusable Blocks...etc without any bugs.
Testing Instructions for Keyboard
Screenshots or screencast