Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviors: Move behaviors code to experimental folder. #51654

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

cbravobernal
Copy link
Contributor

What?

Behaviors are not getting to 6.3. Due to that reason, the code should still be in experimental.

@github-actions
Copy link

Flaky tests detected in a17dfb1.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5312382341
📝 Reported issues:

@cbravobernal cbravobernal added [Feature] Interactivity API API to add frontend interactivity to blocks. [Type] Code Quality Issues or PRs that relate to code quality labels Jun 19, 2023
Copy link
Contributor

@artemiomorales artemiomorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough about how the experimental/ versus compat/ folders work and their implications to offer an approving review, though I can say that I've tested the lightbox functionality and all seems to working as expected 👍

@ramonjd
Copy link
Member

ramonjd commented Jun 20, 2023

This makes sense to me.

PHP changes in /compat/x-y folders correspond to features that have been synched to the x.y releases of WordPress.

It means, for example, that folks who are still running, say, WordPress 6.2, can still use 6.3-compatible features if they have the Gutenberg plugin installed. It also acts as a guide for us so that we have a good idea about which features have made it to Core and which haven't 😄

More info over at the README:

# Gutenberg PHP

So if the changes in this PR are not being ported to WordPress 6.3 then I think /experimental is a valid place for them to live until they're stable/earmarked for a WordPress release.

Thanks!

Copy link
Contributor

@SantosGuillamot SantosGuillamot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙂

@cbravobernal cbravobernal merged commit 4785f90 into trunk Jun 20, 2023
@cbravobernal cbravobernal deleted the update/move-behaviors-to-experimental branch June 20, 2023 07:35
@github-actions github-actions bot added this to the Gutenberg 16.1 milestone Jun 20, 2023
sethrubenstein pushed a commit to pewresearch/gutenberg that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Interactivity API API to add frontend interactivity to blocks. [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants